Improve doc comment for GIDSignInButtonStyle#204
Open
kamimi01 wants to merge 2 commits intogoogle:mainfrom
Open
Improve doc comment for GIDSignInButtonStyle#204kamimi01 wants to merge 2 commits intogoogle:mainfrom
kamimi01 wants to merge 2 commits intogoogle:mainfrom
Conversation
petea
changed the title
Author
|
@petea Hi team, |
monicakh
approved these changes
Jan 19, 2025
w-goog
requested changes
Mar 5, 2026
| /// - kGIDSignInButtonStyleStandard: 230 x 48 | ||
| /// - kGIDSignInButtonStyleWide: 312 x 48 | ||
| /// - kGIDSignInButtonStyleIconOnly: 48 x 48 (no text, fixed size) | ||
| /// - kGIDSignInButtonStyleStandard: 230 x 48 (Display text is "Sign in") |
Contributor
There was a problem hiding this comment.
Future-proofing this a bit :)
Suggested change
| /// - kGIDSignInButtonStyleStandard: 230 x 48 (Display text is "Sign in") | |
| /// - kGIDSignInButtonStyleStandard: 230 x 48 (Example display text: "Sign in") |
| /// - kGIDSignInButtonStyleWide: 312 x 48 | ||
| /// - kGIDSignInButtonStyleIconOnly: 48 x 48 (no text, fixed size) | ||
| /// - kGIDSignInButtonStyleStandard: 230 x 48 (Display text is "Sign in") | ||
| /// - kGIDSignInButtonStyleWide: 312 x 48 (Display text is "Sign in with Google") |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - kGIDSignInButtonStyleWide: 312 x 48 (Display text is "Sign in with Google") | |
| /// - kGIDSignInButtonStyleWide: 312 x 48 (Example display text: "Sign in with Google") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on #203
I think to be customizable the display text is better than adding document comments like this, so this is a workaround.